Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LR11x0] Fix temperature reading #1234

Merged
merged 3 commits into from
Sep 26, 2024
Merged

[LR11x0] Fix temperature reading #1234

merged 3 commits into from
Sep 26, 2024

Conversation

mixeysan
Copy link
Contributor

According LR1121 datasheet
Before:
11:35:15.753 -> 044E
11:35:15.753 -> -427058.1562500000
After:
12:14:17.348 -> 044E
12:14:17.348 -> 23.39

Pull request template

Thank you for taking the time to contribute to RadioLib development!
To keep this library organized, please follow these rules.

  1. Make sure the the code in your PR is tested and that you understand all its impacts.
  2. Ensure that all CI actions pass - PRs with failed CI will not be merged. CI actions run automatically for every commit pushed to the PR and test the following:
    a. Compilation for Arduino, ESP-IDF and on Raspberry Pi
    b. Runtime test on Raspberry Pi
    c. GitHub CodeQL check
    d. Cppcheck static code scan
  3. Follow code style guidelines in CONTRIBUTING.md
  4. Heads up - all PRs undergo review, during which you may be asked to correct or change some things. The purpose of this review is to keep regressions and bugs at the minimum, and to keep consistent coding style. Please take them as constructive criticism from people who may have a different point-of-view than you do.

After addressing/accepting the points above, delete the contents of this template and replace it with text explaining what is the goal of your PR, why you want to add it to the upstream and what are the foreseen impacts. Once again, thank you for taking the time to contribute!

According LR1121 datasheet
@jgromes
Copy link
Owner

jgromes commented Sep 26, 2024

Thank you for the contribution, it is appreciated and can be merged. However, next time, please try to explain what is the change actually achieving - commits titled "Update LR11x0.cpp" don't tell me anything about the nature of the change.

@jgromes jgromes changed the title Update LR11x0.cpp [LR11x0] Fix temperature reading Sep 26, 2024
@jgromes jgromes merged commit a68df0f into jgromes:master Sep 26, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants