Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SX127x] Fix missing CRC mismatch error #1236

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

GUVWAF
Copy link
Contributor

@GUVWAF GUVWAF commented Sep 26, 2024

After upgrading to version 7.0 we saw that SX127x radios sometimes got garbled data through. Seems due to #1184 the variable state gets overwritten (normally to 0) and thus it would loose a potential RADIOLIB_ERR_CRC_MISMATCH set before this.
I therefore introduced a new variable for it, and I also moved the SPI calls outside the else clause, because the data might still be valuable even if the header is damaged.

@jp-bennett
Copy link
Contributor

Just tested this with Meshtastic master and a T-Beam with the older RF95 chipset. With this patch, we are once again catching CRC errors. Thanks!

@jgromes jgromes merged commit ce673b2 into jgromes:master Sep 26, 2024
30 checks passed
@jgromes
Copy link
Owner

jgromes commented Sep 26, 2024

Good catch - merged, thank you! This looks like a rather serious issue (price we pay for not releasing more often I suppose ...), I will see if we can get 7.0.1 out in the next few days.

@GUVWAF GUVWAF deleted the SX127xCRC branch September 26, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants