[SX127x] Fix missing CRC mismatch error #1236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to version 7.0 we saw that SX127x radios sometimes got garbled data through. Seems due to #1184 the variable
state
gets overwritten (normally to 0) and thus it would loose a potentialRADIOLIB_ERR_CRC_MISMATCH
set before this.I therefore introduced a new variable for it, and I also moved the SPI calls outside the
else
clause, because the data might still be valuable even if the header is damaged.