added my data augmentation changes #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrss
reviewed
Jun 18, 2022
| @@ -331,7 +331,7 @@ def create_image_vars( | |||
| .clip(0, 1)) | |||
|
|
|||
| # Get the band count per index | |||
| nbands = int(src_ts.gw.nbands / len(list(set([Path(fn).parent.name for fn in image])))) | |||
| nbands = len(list(set([Path(fn).parent.name for fn in image]))) | |||
There was a problem hiding this comment.
Thanks for this fix to allow the use of single-band inputs.
The variable name is correct with this change. However, this change impacts the downstream 'flip' augmentation because I was previously using nbands as ntime.
See additional modifications in PR #19
There was a problem hiding this comment.
So I actually wanted to ask you about flipfb, I currently have it turned off. Is the intention of it to reverse time, or is it to reverse the bands? If the latter, I imagine it would be best to have it off if I am using NRGB, correct? (since I don't want it reversing those?) Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes I've made regarding the data augmentation.
The change in create is what I believe is the appropriate change to fix the time series error I was getting before.
I have set up roll so that it rolls over time a given number of time steps (or percent).
So roll2 (or rolls2) will roll the time step by 2, rollp25 will roll the time series by 25% of the number of time steps.