jgrss/#242

[jgrss]

What is this PR changing?

Following #242, this changes Path.rename to Path.replace in order to handle files in Windows.

[jgrss]

@mmann1123 Can you do one more quick look? I added a test and deprecated an inconsistent argument.

[mmann1123]

@jgrss sure give me a bit

[mmann1123]

I am getting an error on coreg... but might have to do with my build.

======================================================================
ERROR: test_coreg_data (test_coreg.TestCOREG)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/geowombat/tests/test_coreg.py", line 29, in test_coreg_data
    data = gw.coregister(
  File "/geowombat/src/geowombat/core/sops.py", line 1230, in coregister
    raise NameError
NameError

======================================================================
ERROR: test_coreg_shift (test_coreg.TestCOREG)
Tests a 1-pixel shift.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/geowombat/tests/test_coreg.py", line 79, in test_coreg_shift
    shifted = gw.coregister(
  File "/geowombat/src/geowombat/core/sops.py", line 1230, in coregister
    raise NameError
NameError

======================================================================
ERROR: test_coreg_transform_data (test_coreg.TestCOREG)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/geowombat/tests/test_coreg.py", line 50, in test_coreg_transform_data
    data = gw.coregister(
  File "/geowombat/src/geowombat/core/sops.py", line 1230, in coregister
    raise NameError
NameError

----------------------------------------------------------------------
Ran 88 tests in 20.577s
FAILED (errors=3)

[jgrss]

I am getting an error on coreg... but might have to do with my build.

======================================================================
ERROR: test_coreg_data (test_coreg.TestCOREG)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/geowombat/tests/test_coreg.py", line 29, in test_coreg_data
    data = gw.coregister(
  File "/geowombat/src/geowombat/core/sops.py", line 1230, in coregister
    raise NameError
NameError

======================================================================
ERROR: test_coreg_shift (test_coreg.TestCOREG)
Tests a 1-pixel shift.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/geowombat/tests/test_coreg.py", line 79, in test_coreg_shift
    shifted = gw.coregister(
  File "/geowombat/src/geowombat/core/sops.py", line 1230, in coregister
    raise NameError
NameError

======================================================================
ERROR: test_coreg_transform_data (test_coreg.TestCOREG)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/geowombat/tests/test_coreg.py", line 50, in test_coreg_transform_data
    data = gw.coregister(
  File "/geowombat/src/geowombat/core/sops.py", line 1230, in coregister
    raise NameError
NameError

----------------------------------------------------------------------
Ran 88 tests in 20.577s
FAILED (errors=3)

Hmm, was that a new build? All tests just passed on this PR branch.

[mmann1123]

@jgrss I think its just an issue with how I did the dockerfile.