Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[271] jgrss/band res #282

Merged
merged 5 commits into from
Oct 2, 2023
Merged

[271] jgrss/band res #282

merged 5 commits into from
Oct 2, 2023

Conversation

jgrss
Copy link
Owner

@jgrss jgrss commented Jul 15, 2023

What is this PR changing?

Following #271, this PR adds a check for coordinate alignment and a warning when concatenation inputs are not aligned.

@@ -57,7 +73,9 @@ def test_nodata(self):
self.assertEqual(src.gw.nodataval, 0)

def test_open_multiple(self):
with gw.open([l8_224078_20200518, l8_224078_20200518], stack_dim='time') as src:
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here and below is black formatting.

@jgrss jgrss marked this pull request as ready for review July 16, 2023 00:04
@jgrss jgrss requested a review from mmann1123 July 16, 2023 00:04
Copy link
Collaborator

@mmann1123 mmann1123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@mmann1123
Copy link
Collaborator

@jgrss did this get stalled somehow?

@jgrss
Copy link
Owner Author

jgrss commented Oct 2, 2023

@jgrss did this get stalled somehow?

I guess so -- just fell off my radar.

@jgrss jgrss merged commit ffcb3f3 into main Oct 2, 2023
3 checks passed
@jgrss jgrss deleted the jgrss/band_res_271 branch October 2, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants