-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adding random forest classifier test which breaks #301
Conversation
had to set scikit-learn to 1.2.0 to fix the issue
@jgrss after a bit of mussing about this is ready to look at |
self.assertTrue(np.all(np.isnan(y2.values[0, 0:5, 0]))) | ||
self.assertTrue( | ||
np.allclose( | ||
y1.values[0, -5:-1, 0], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious what's going on here with the indexing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just grabbing some portion of the values to compare. I guess I really don't need to do that but oh well.
@jgrss I am not sure what the "Tests - waiting for status to be reported" is. What's the plan for merging here? |
I can merge it. |
thanks for fixing this! |
I identified an untested bug in geowombat. Basically sklearn-xarray needs scikit-learn=1.2.0 or it breaks with forest estimators. Adding test and trying to limit scikit version in setup.cfg for ml add-on install.
had to set scikit-learn to 1.2.0 to fix the issue
What is this PR changing?
Add a description
Checklist
Tag options:
Example: