-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move sass
to devDependencies
#3737
Comments
I understand your argument regarding the use of sass as only a dev dependency, however, why would you install Bulma in the first place, if all you want is the finalized CSS? You could simply use the CSS from a CDN, or just use a local copy of it for your build. |
Using Sass or compiled CSS files shouldn't impact the global logic of our toolchain (= how we install dependencies, how we bundle our application, etc.), even if, obviously, some more tools and configurations may need to be added in the middle of it, depending on the choice we make. From my point of view, that's the entire point of having compiled CSS files published in the NPM package together with Sass source files: to allow us to include Bulma in our application and in our development & build process (without changing its global logic), whether we're working with Sass or vanilla CSS (the later being a totally valid choice, not everyone will need Sass in order to use Bulma). And if we have this choice, Sass dependency shouldn't be enforced. Nothing exceptional here in my opinion, this is how Bulma was working before ( |
This is about Bulma. It is an optimization/enhancement request.
Overview of the problem
This is about the Bulma CSS framework, more precisely about the published NPM package.
I'm using Bulma version 1.0.0.
This issue doesn't seem to be a duplicate.
Description
TL;DR Installing
sass
shouldn't be mandatory for developers using only CSS files.sass
has been added as a dependency of the NPM package (to promote its usage with Bulma v1?), increasing dramatically the package size.sass
dependency could be moved todevDependencies
in order to reduce the package installation size, developers can still installsass
when they need to use Bulma Sass files.Steps to Reproduce
Install
bulma@1.0.0
NPM package (to use only CSS files).Expected behavior
sass
dependency installation shouldn't be forced when we only want to use Bulma CSS files.Actual behavior
sass
is a dependency ofbulma@1.0.0
and is installed automatically by NPM, even if uneeded.P.S. Thanks for your work on the v1, it's great to see that this project is still alive 🎉
The text was updated successfully, but these errors were encountered: