Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue with transforms being left after drop #156

Merged
merged 1 commit into from
Oct 19, 2017

Conversation

shidel-dev
Copy link
Contributor

@shidel-dev shidel-dev commented Oct 4, 2017

fixes #132.

_drag was being invoked after reset was called on the item, and after a drop.

@shidel-dev
Copy link
Contributor Author

shidel-dev commented Oct 5, 2017

Not sure if there is a way to have the events stop firing after a drop occurs (it seems to only happen in some cases). I just did some debugging to get my information (placed logs in _drag, and reset and saw what order they were happening in when things went wrong).

@shidel-dev
Copy link
Contributor Author

It was also unclear if I should make my changes on the 1.x branch or master. I tried out the master branch in my application, and it seems to have issues with performance, and also it seems as if my "handle" on the element is coming loose. I did not dive into this. perhaps there is an api change I am not aware of.

@shidel-dev
Copy link
Contributor Author

shidel-dev commented Oct 5, 2017

I do have a version of my changes for the master branch as well.

@mupkoo
Copy link
Contributor

mupkoo commented Oct 10, 2017

I have the same problem and this patch seems to solve it.

@jgwhite
Copy link
Contributor

jgwhite commented Oct 18, 2017

Thanks so much for this patch and sorry it hasn’t received any attention. I can’t make any exact promises about when it’ll be merged but don’t let us off the hook, we’ll get there!

@jgwhite jgwhite merged commit 81889f6 into adopted-ember-addons:1.x Oct 19, 2017
@jgwhite
Copy link
Contributor

jgwhite commented Oct 19, 2017

Thanks so much for the patch! I’ll try to release it later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants