Don't throw an error on missing russrc #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aintain concatenation order
…aintain concatenation order
…ng with pre/post hooks
jh3y
reviewed
Jun 30, 2017
| } catch (err) { | ||
| throw Error('Missing russ files...'); | ||
| } | ||
| } catch (err) { } |
There was a problem hiding this comment.
Not sure tasks need to be defined twice here. But, based on #5 this path will likely need to be a variable that's defined based on whether the config exists and a key is set or a command line option has been set to define the task directory.
jh3y
reviewed
Jun 30, 2017
| @@ -176,7 +175,7 @@ var RussInstance = function () { | |||
| var isDel = opts.concurrent || opts.sequence; | |||
| if (opts.name && opts.doc && (hasFunc || isDel)) _this4.tasks[opts.name] = opts;else throw new Error(ERR_MSG); | |||
| }; | |||
| if (files.length === 0) throw new Error('No tasks defined in russ.tasks'); | |||
| if (!files || files.length === 0) throw new Error('No tasks defined in russ.tasks'); | |||
There was a problem hiding this comment.
If tasks definition is left inside try/catch the file check within register shouldn't be necessary, it will either throw an error because the directory doesn't exist or will throw an error that no tasks are defined because of an empty files array. In which case the check could just simply be:
if (!files.length) throw new Error('No tasks defined in russ.tasks');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be optional if user doesn't need to put anything in it.