Proposed changes for "Avoid static list of Addresses in ConnectionHandler" #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 22, 2013 11:59
… attempt for a connection. This is towards issue jhalterman#17 (jhalterman#17)
…anged the AddressResolver to the second option that was discussed since it is more adaptable to underlying AMQP library.
jhalterman
force-pushed
the
master
branch
3 times, most recently
from
74bfe02
to
dbcd649
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among the options discussed, have chosen Option 2 since it easily integrates with the underlying AMQP library. This option only makes a minimal intrusion in the underlying code.
An AddressResolver is introduced and is referenced in the ConnectionOptions. Whenever a connection is being re-attempted, the resolver is called back to retrieve the set of addresses.