UTF-8 as default for file sources #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I understand the tests correctly, only one of these tests methods are relevant for eaxy used in this context. If you agree, remove the other tests and I'll merge the pull request. |
added 2 commits
October 1, 2014 12:56
|
The challenge was to make a test suite that would fail if I think I manged to wrap it all into a single sane test case now, albeit with two asserts. |
jhannes
added a commit
that referenced
this pull request
Oct 6, 2014
UTF-8 as default for file sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XML.read() uses the system default encoding (ignoring what the file itself says).
The correct thing would be to look for a charset attribute in the XML header, defaulting to any BOM-specified encoding if it is not there, and lastly default to UTF-8 if there is no BOM.
This quick fix still ignores what the file says, but defaults straight to UTF-8 and is at least slightly less likely to cause problems.