Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideally the only required software to run the pipeline should be Nextflow and Docker/Singularity. I would suggest review the installation instructions, requiring a conda env. shouldn't be required. #36

Closed
Tracked by #26
jhayer opened this issue Jun 12, 2023 · 2 comments

Comments

@jhayer
Copy link
Owner

jhayer commented Jun 12, 2023

No description provided.

@mberacochea
Copy link

mberacochea commented Jul 9, 2023

Hi! Thank you for the changes; I think they are a great improvement.

I understand the usefulness of https://github.com/jhayer/baargin/blob/main/download_db.py, but this is the main reason for the requirement of a Conda environment. By also providing a set of curl or wget commands, it would be possible to make the Conda environment not required. The most technically savvy users will probably notice this. I feel that not having a Conda environment makes using the pipeline more accessible, especially for Nextflow users.

For plasmidfinder_db , it's possible to download the repo using the Bibucket Download Repo URL: https://bitbucket.org/genomicepidemiology/plasmidfinder_db/get/314d85f43e4e.zip.

Something like:

mkdir dbs/plasmidfinder
cd dbs/plasmidfinder
wget https://bitbucket.org/genomicepidemiology/plasmidfinder_db/get/314d85f43e4e.zip -O plasmidfinderdb && unzip -j plasmidfinderdb.zip

@jhayer
Copy link
Owner Author

jhayer commented Jul 24, 2023

Hi ! Thank you for the comments.
We had actually added a "manually" section to the documentation for the databases download (using wget, curl or git clone).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants