-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings refactor #193
base: main
Are you sure you want to change the base?
Settings refactor #193
Conversation
Is there anything else that you think should be moved to the settings? If it's just the captioning device, I don't think we have enough settings there yet to switch to tabs. |
show/hide probabilities, load in 4 bit, device is 2 settings: device and index. (could be 1 for the more advanced users. cuda:0/cpu/cuda:1/whatever. but less advanced use gpu vs cpu and gpu index) overall, with all that is in it now, this is definitely rather barebones of a change. with the options above that may be included, this PR is a futureproofing technique. would be easier to add it now and then as new settings are added, put them in the right place than add later and try moving when there is many settings. |
I think some of those should be left where they are (like "show probabilities"). Maybe you could not move any settings in this PR, and we can move and add settings separately later. |
oh? then I guess its ready as is (except let me move extensions to directory.) |
what is vsc doing to me? why does it have a merge branch when I just push a change? |
makes settings menu have tabs. probably could use side tabs instead of top tabs. depends on number of submenus, but that is down the road.
need to move some more settings to this before its confirmed. at minimum captioning device. but what else?