desktop interface: Fix OpenURI in Core Desktop #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
org.freedesktop.portal.OpenURI doesn’t work in core desktop. For example, opening Gnome Control Center->Privaty->Location Services and clicking on “Privacy Policy” doesn’t work. This patch fixes it.
jhenstridge
pushed a commit
that referenced
this pull request
Aug 30, 2023
interfaces: Update tests for upower-observe change
jhenstridge
pushed a commit
that referenced
this pull request
Jan 15, 2024
Add the apparmor prompting listener, formerly named notifier. Initial commit for apparmor prompting notifier Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com> Signed-off-by: Oliver Calder <oliver.calder@canonical.com> Do not wait for .notify writablility events We are only interested in the reading side, which corresponds to incoming requests. This surprisingly fixes the multi-request issue that I was experiencing before, allowing us to process requests asynchronously. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com> Signed-off-by: Oliver Calder <oliver.calder@canonical.com> Process requests asynchronously This allows us to wait for multiple responses from userspace and still process incoming kernel message. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com> Signed-off-by: Oliver Calder <oliver.calder@canonical.com> Move the Notifier to a dedicated package The Notifier is a high-level abstraction that does not leak any apparmor implementation details directly. As such it should be in a different package. Some methods were adjusted to better accommodate the new package name. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com> Signed-off-by: Oliver Calder <oliver.calder@canonical.com> Don't log request/responses Those are very low level and they don't add anything at the current stage of development. Instead provide a quieter but more readable interface. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com> Signed-off-by: Oliver Calder <oliver.calder@canonical.com> Merge pull request #14 from snapcore/feature/decode-file-perms Add opaque Permission attribute to notification requests Signed-off-by: Oliver Calder <oliver.calder@canonical.com> notifier: improve error messages Signed-off-by: Oliver Calder <oliver.calder@canonical.com> Merge pull request #13 from snapcore/feature/file-perm Model file permissions described by notification messages Signed-off-by: Oliver Calder <oliver.calder@canonical.com> many: rework for new RegisterAgent based API Signed-off-by: Oliver Calder <oliver.calder@canonical.com> prompting: set all prompt replies to "no-cache" for now Signed-off-by: Oliver Calder <oliver.calder@canonical.com> prompting/notifier: added `tomb` parameter to `Run()` so it can be safely terminated Signed-off-by: Oliver Calder <oliver.calder@canonical.com> sandbox/apparmor/notify: renamed `notifier` to `listener` as sub-package of `notify` Signed-off-by: Oliver Calder <oliver.calder@canonical.com> sandbox/apparmor/notify/listener: improved unit tests Signed-off-by: Oliver Calder <oliver.calder@canonical.com> sandbox/apparmor/notify/listener: improved unit tests for error handling Signed-off-by: Oliver Calder <oliver.calder@canonical.com> s/apparmor/notify/listener: reformatted and renamed listener code Signed-off-by: Oliver Calder <oliver.calder@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.freedesktop.portal.OpenURI doesn’t work in core desktop. For example, opening Gnome Control Center->Privaty->Location Services and clicking on “Privacy Policy” doesn’t work.
This patch fixes it.
This patch is the upstream version of canonical#17; but since the upstream snapd still lacks a slot for the desktop interface, I add it here.
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?