Linux Support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addisoncrump
commented
Oct 31, 2022
| + } |
There was a problem hiding this comment.
This was actually preventing me from applying the patch on Linux. GNU patch doesn't support no endline.
addisoncrump
commented
Oct 31, 2022
| @@ -250,7 +263,7 @@ impl CompilerWrapper for ClangWrapper { | |||
| return Ok(args); | |||
| } | |||
|
|
|||
| if !self.passes.is_empty() { | |||
| if !self.passes.is_empty() && cfg!(target_vendor = "apple") { | |||
| args.push("-fno-experimental-new-pass-manager".into()); | |||
There was a problem hiding this comment.
This is no longer necessary on Linux (>9.0.0 LLVM)
addisoncrump
commented
Oct 31, 2022
|
|
||
| # allow for symlinks | ||
| outdir="$(dirname "$(dirname "$PWD")")"/out/jif |
There was a problem hiding this comment.
This allows you to symbolically link jif into the chromium source tree.
addisoncrump
commented
Oct 31, 2022
| @@ -4,7 +4,8 @@ | |||
|
|
|||
| * setup a chromium repo: https://www.chromium.org/developers/how-tos/get-the-code | |||
| * note that this will take several hours | |||
| * `mv jif $root/chromium/src/headless/jif` | |||
| * you MUST use revision: fc68e53944be7 | |||
There was a problem hiding this comment.
unmanageable and utter agony
|
It works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, haven't actually built this yet (as discussed in DMs)