Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

International file name handling during encode #55

Closed
jhillyerd opened this issue Jan 28, 2018 · 0 comments
Closed

International file name handling during encode #55

jhillyerd opened this issue Jan 28, 2018 · 0 comments
Assignees
Milestone

Comments

@jhillyerd
Copy link
Owner

jhillyerd commented Jan 28, 2018

Golang's mime.FormatMediaType does not handle non-ASCII characters. PR #54 escapes non-ASCII characters with \u1234 notation.

RFC 2616 sec 2.2 does not define any special meaning for backslash quoted characters. In other applications I've seen non-ASCII characters converted to underscores for filenames, but I feel we can do better.

My suggestion is to remove all accent marks from alphabetic characters (ie À -> A, ó -> o), then convert any remaining non-ASCII characters to underscores.

@jhillyerd jhillyerd changed the title International file name handling International file name handling during encode Jan 28, 2018
@jhillyerd jhillyerd self-assigned this Feb 18, 2018
@jhillyerd jhillyerd added this to the v0.2 milestone Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant