Fix for certain charset duplicate params error #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l mime parsing fails. - Handle misplaced ; in content-type - Handle empty name in content-type - Added a test
|
It seems like your new error path for missing |
|
@jhillyerd Nice catch, didn't know about coveralls. 👍 |
|
@jhillyerd Done. Please review. |
|
@jhillyerd mime.ParseMediaType is used in several places. I think a better fix is to create a function parseMediaType which can then call mime.ParseMediaType and then if that fails call parseBadContentType. This will cover duplicate parameters fixes across Content-Type everywhere (envelope, parts, etc.). Thoughts? I'll update this PR soon. |
|
Looks great, thank you! |
jhillyerd
added a commit
that referenced
this pull request
Jun 20, 2023
If charset is missing from the mime header look for it in the html meta tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a duplicate param is present then parsing of the entire email fails. This fix handles a misplaced ";" in content-type. It also handles empty name in content-type. I have also added a unit test for this scenario.