add io.Reader interface for attachment content #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can provide a significant optimization in memory usage when encoding large attachments - the attachment is stored only once (in the final message), instead of 3 times (part.Content, the base64 encoded buffer and the final message)
jhillyerd
requested changes
Jul 26, 2023
There was a problem hiding this comment.
Thanks for this. One concern I have is that the builder was designed to be safe to "fork" in the sense that it always returns a copy of itself. ie you could setup the content, store that copy, then loop over your recipients, adding each one and sending the returned copy.
I suspect storing a content reader would mean only the first use of any particular set of copies would function, and the rest would just see an EOF. Not the end of the world, but I think it needs to be called out in the builder doc comment.
|
Thanks @jhillyerd! added the requested comments |
|
ping :) |
jhillyerd
approved these changes
Aug 7, 2023
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can provide a significant optimization in memory usage when encoding large attachments - the attachment is stored only once (in the final message), instead of 3 times (part.Content, the base64 encoded buffer and the final message)