Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export readHeader as ReadHeader. #306

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

davrux
Copy link
Contributor

@davrux davrux commented Oct 11, 2023

The function is excellent at parsing SMTP and MIME headers. It would be great to use this function in other projects.

The function is excellent at parsing SMTP and MIME headers. It would be
great to use this function in other projects.
@coveralls
Copy link

Coverage Status

coverage: 86.001% (+0.04%) from 85.966% when pulling 0bab430 on davrux:read-header into 6241177 on jhillyerd:main.

@iredmail
Copy link
Contributor

Is it necessary to export AddError and AddWarning?

@davrux
Copy link
Contributor Author

davrux commented Oct 12, 2023

Yes, without export an external package won't be able to implement the interface.

@jhillyerd jhillyerd merged commit e6dab52 into jhillyerd:main Oct 16, 2023
9 checks passed
@jhillyerd
Copy link
Owner

Sounds like a good idea to me, thanks!

@davrux davrux deleted the read-header branch October 16, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants