Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many draft releases from release drafter #18319

Closed
deepu105 opened this issue Apr 7, 2022 · 13 comments
Closed

Too many draft releases from release drafter #18319

deepu105 opened this issue Apr 7, 2022 · 13 comments
Assignees
Labels
area: triage $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: undefined $200 https://www.jhipster.tech/bug-bounties/
Milestone

Comments

@deepu105
Copy link
Member

deepu105 commented Apr 7, 2022

It seems like there are too many draft releases created by release drafter as if it's being created for every merge. We should change it so that its generated only when a new tag is pushed

Also the dates on the created draft seems to be wrong

https://github.com/jhipster/generator-jhipster/releases.

@deepu105 deepu105 added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Apr 7, 2022
@atomfrede
Copy link
Member

I can do the monkey work this evening, have some time.

@pascalgrimaud
Copy link
Member

@atomfrede : only keep the most recent one :-)

@atomfrede
Copy link
Member

I will now remove all drafts except the last one and try to exclude certain PRs from release drafter (especially dependabot, it's really too much)

@atomfrede
Copy link
Member

I have also removed the latest draft, such that release drafter can create a new one with correct date too.

@atomfrede
Copy link
Member

At first it looks good imho. Drafted release notes are empty by default, added the release-notes label to certain PRs.

@atomfrede
Copy link
Member

Works fine, let's close this, if we need to/want to further adapt the config let's do that in another issue.

@atomfrede
Copy link
Member

Bounty claimed https://opencollective.com/generator-jhipster/expenses/71751

@mshima
Copy link
Member

mshima commented Apr 8, 2022

@atomfrede the release-notes tag is required?
Should it be added to labeler https://github.com/jhipster/generator-jhipster/blob/main/.github/labeler.yml?

The 2 first v7.8.1 release note entries are not included at the release.

@atomfrede
Copy link
Member

My idea was to mark entries explicit to make them eligible for the release note page

@mshima
Copy link
Member

mshima commented Apr 8, 2022

IMO we should add every PR to release note, just keep Dependabot out.

@pascalgrimaud
Copy link
Member

I'm fine with what @mshima suggests
What do you think @atomfrede ?

@atomfrede
Copy link
Member

Also fine for me, guess keeping them out will help already to have better release notes.

atomfrede added a commit to atomfrede/generator-jhipster that referenced this issue Apr 8, 2022
@atomfrede
Copy link
Member

Updated the config with #18327

@DanielFran DanielFran added this to the 7.9.0 milestone Jun 22, 2022
DanielFran added a commit to DanielFran/generator-jhipster that referenced this issue Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: triage $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: undefined $200 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

No branches or pull requests

5 participants