Cannot create the user without an activation email

[kazoompa]

Motivation for or Use Case

Our client application requires that the user be created without any activation to proceed with the game. To do that, I have modified the UserService.createUser() so that activationKey is set to NULL and activated is set TRUE. I also provide the input password the user has provided. The user gets created without a problem but cannot login due to this error:

{"error":"invalid_grant","error_description":"Bad credentials"}

I tried to debug and discovered that the error is in this code:

if(authentication.getCredentials() == null) {
  this.logger.debug("Authentication failed: no credentials provided");
  throw new BadCredentialsException(this.messages.getMessage("AbstractUserDetailsAuthenticationProvider.badCredentials", "Bad credentials"));
} else {
  String presentedPassword = authentication.getCredentials().toString();
  // PROBLEM IS INVALID PASSWORD!!!!
  if(!this.passwordEncoder.isPasswordValid(userDetails.getPassword(), presentedPassword, salt)) {
    this.logger.debug("Authentication failed: password does not match stored value");
    throw new BadCredentialsException(this.messages.getMessage("AbstractUserDetailsAuthenticationProvider.badCredentials", "Bad credentials"));
  }
}

The salt is NULL but the password is definitely correct! I was wondering if I was miss a step or this is a bug.

Any help is greatly appreciated.

JHipster Version(s)

1.8.3

JHipster configuration, a .yo-rc.json file generated in the root folder

{
  "generator-jhipster": {
    "jhipsterVersion": "3.4.2",
    "baseName": "afgserver",
    "packageName": "com.afg.server",
    "packageFolder": "com/afg/server",
    "serverPort": "8080",
    "authenticationType": "oauth2",
    "hibernateCache": "ehcache",
    "clusteredHttpSession": "no",
    "websocket": "no",
    "databaseType": "sql",
    "devDatabaseType": "mysql",
    "prodDatabaseType": "mysql",
    "searchEngine": "no",
    "buildTool": "maven",
    "useSass": true,
    "applicationType": "monolith",
    "testFrameworks": [
      "gatling"
    ],
    "jhiPrefix": "jhi",
    "enableTranslation": true,
    "nativeLanguage": "en",
    "languages": [
      "en",
      "fr"
    ]
  }
}

Browsers and Operating System

Debian 8
Safari, Chrome

[jdubois]

I have no idea what happens if the salt is "NULL", but appart from the part that it's a bad idea (and illegal in some countries, like mine), if you don't want the salt, then remove the password encryption altogether.

That's more a question for StackOverflow, and not a JHipster bug, so I'm closing this.