Fix Istio URL issues #10138
Merged
Fix Istio URL issues #10138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srinivasa-vasu @PierreBesson can you guys take a look. I had to make these changes to make Istio work on GKE with latest versions |
4 tasks
deepu105
force-pushed
the
issue-10135
branch
from
e9a765b
to
ca33637
Compare
|
@srinivasa-vasu I retained the namespace in url, everything works fine now |
|
Since the build queue is huge, I'm running the tests locally |
|
Bounty request https://opencollective.com/generator-jhipster/expenses/10054 |
|
@deepu105 : just approuved :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10135
Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed