Replace deprecated StringUtils.isEmpty() by ObjectUtils.isEmpty() and cover its usage with tests
#13369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ramnaq
force-pushed
the
replace-deprecated-method
branch
2 times, most recently
from
b6f9fda
to
8bdf2d7
Compare
ramnaq
force-pushed
the
replace-deprecated-method
branch
from
8bdf2d7
to
3eb5107
Compare
ramnaq
changed the title
StringUtils.isEmpty() by ObjectUtils.isEmpty() and cover its usage with tests
|
Thanks @ramnasidharta for tour contribution |
DanielFran
approved these changes
Dec 29, 2020
sendilkumarn
added a commit
to jhipster/jhipster-kotlin
that referenced
this pull request
Feb 27, 2021
…ty()` and cover its usage with tests Refer jhipster/generator-jhipster#13369
sendilkumarn
added a commit
to jhipster/jhipster-kotlin
that referenced
this pull request
Apr 18, 2021
…ty()` and cover its usage with tests Refer jhipster/generator-jhipster#13369
sendilkumarn
added a commit
to jhipster/jhipster-kotlin
that referenced
this pull request
Apr 18, 2021
* finished first cut for 7.0.0 release * feat: upgrade the entity generator to v7 beta * feat: upgrade server generator to v7 * feat: upgrader server generator to v7 * feat: update configuration to v7 * feat: migrate web/rest to v7 * feat: upgrade security to v7.0 * migrate repository tov v7 beta * migrate service to v7 beta * feat: upgrade config test directory to version 7 * migrate cucumber to v7 * feat: migrate gateway to v7 * feat: migrate repository test to v7 * feat: migrate security/jwt to v7 * feat: migrate cookie token extractor to v7 * feat: migrate security to v7 * feat: migrate mapper to v7 * feat: migrate service and test service to v7 * feat: migrate rest resources to v7 * feat: migrate Cassandra config test utils to v7 * fix: type configuration fixes * feat: migrate test and test integration scripts to v7 * migrate workflows to v7 step 1 * migrate tests and integration scripts * feat: migrate files to v7 * fix: use proper generic import * feat: upgrade other files to v7 * feat: update expected-files to v7 * feat: update app spec to v7 * feat: test updates and remove import static * add missing jhi_clone path * fix: lint fixes * fix ejs lint error * fix: remove duplicate sonar analysis * fix template lint issues * feat: fix build issues * fix: entity server unit test * fix: failing test case because of missing prettier transform * remove withAudit configuration * feat: add postWriting in server configuration * rename primaryKeyType to primaryKey.type * rename JHipsterBlockHoundIntegration * compilation fixes * fix: some more bugs * fix: add fun modifier for functions * fix: remove extra braces and use proper field accessor * fix: add a line break between package and import * fix: add secondary constructor for the UserDTO * fix: use proper variable declaration in patch_tempalte * fix di and type selection * fix: add variable name * fix: migrate entity generator to v7 and few other fixes * fix: make converters as an object * fix: remove trailing commas * fix: remove return type reference * fix: use kotlin class reference * fix: infer type * fix build file issue * fix: template string * fix: mongodb kafka app generation * fix: enity configuration and lint issues * remove couchbase and fix kapt * fix: react ci build issues * lint fix * fix generated services and entities * fix react builds and remove couchbase builds * make authorities proper * Upgrade kotlin to latest version * fix test failures in react default application * lint fixes and failing unit test fixes * fix: add a proper script folder * fix: update cloned path for angular ci * revert change * fix more type issues * Update EntityResourceIT.kt.ejs * fix react ci tests * Update PublicUserResource.kt.ejs * webflux fixes * feat/webflux fixes for v7 migration * few more fixes * fix cucumber tests * replace proper cassandra version variable * fix: workflow and kotlinify * feat: add support for --pk-type part of jhipster/generator-jhipster#13296 * Add support to `@MapstructExpression` Refer jhipster/generator-jhipster#13195 * fix: Replace deprecated `StringUtils.isEmpty()` by `ObjectUtils.isEmpty()` and cover its usage with tests Refer jhipster/generator-jhipster#13369 * chore: Change from 'idx in' to 'item of' for fields and relationships at server templates. Refer jhipster/generator-jhipster#13382 * fix: Neo4j relation rework Refer jhipster/generator-jhipster#13106 * fix: Swagger UI for reactive applications Refer jhipster/generator-jhipster#13409 * fix: sonar code smells Refer jhipster/generator-jhipster#13408 * chore: typo updates * feat: Add custom claim converter in a microservice with oauth2 Refer jhipster/generator-jhipster#12609 * fix: import fixes for custom claim converter test * fix: Fix reactive tests by assigning @NotNull a default message Refer: jhipster/generator-jhipster#13483 * fix: R2DBC with OAuth Refer jhipster/generator-jhipster#13485 * fix: Remove Transactional when using no db Refer: jhipster/generator-jhipster#13489 * fix: Ensure /websocket/tracker/ cant bypass Refer: jhipster/generator-jhipster#13440 * fix: Fix R2DBC with OAuth Refer: jhipster/generator-jhipster#13493 * chore: fix minor code smells * fix: Broken Swagger with Microservice Refer: jhipster/generator-jhipster#13446 * fix: minor updates Refer: jhipster/generator-jhipster#13495 * fix: Change save template to use precedence Refer: jhipster/generator-jhipster#12802: jhipster/generator-jhipster#12802 * fix: add where clause from data jpa criteria when reactive Refer: jhipster/generator-jhipster#13515 * fix: update dependencies and linting fixes * fix: Update build pipeline versions * fix: Angular workflow * fix: copy error * fix: missing otherEntityRelationshipNamePlural variable * fix: ci script * fix: remove unsupported hr language * fix: more angular ci fixes * fix: more angular ci fixes * fix: move CustomClaimConverter to security package * fix: expected files * fix: ci to use installed version of jhipster * rename webpack profile to webapp * fix: refactor ci test * fix: scripts path * fix use proper path * fix: add script level JHI_HOME * fix: use correct kotlin-samples folder * chore: [ci] update chmod * fix: missing variable and correct file location * chore: [CI] add JHI_SCRIPTS location * chore: [CI] add JHI_CLONED_SCRIPTS location * chore: [CI] add HOME location * chore: [CI] add HOME location * Use tilde for home folder * remove 13-replace-jhipster-version script * temp: check scripts folder * fix: use local scripts * chore: [CI] add default work directory * fix: use leading comma * chore: [CI] remove additional app test * minor fixes * fix: use proper primary key name * fix: replace id with primaryKey.type * chore: [CI] add react workflow * chore: [CI] upgrade angular workflow * chore: [CI] add webflux workflow * fix: entityResource * chore: [CI] more workflow changes * chore: [CI] Remove prettier check * chore: [CI] fix react and webflux workflow * fix: add UUID import for cassandra * chore: [CI] use proper script for webflux * fix: use apply instead of constructor params * fix: change the constructor params * fix: add UUIDFilter import for entity criteria * fix: make queryservice to use properly typed filter * fix: tests to have proper primarykey reference * fix: use proper type for filter in EntityQueryService * fix: type issues * fix: redis configuration of test containers * fix: generator entity spec test * fix: entity post fix * chore: [Test] Lint fixes * chore: remove maven cucumber tests * fix: sql webflux issues * fix: use property accessor instead of getter * chore: CI remove kafka test case * fix: remove string utils * Update EntityRepositoryInternalImpl_reactive.kt.ejs * fix: add test fixes and other converters * feat: migrate templates to v7 * lint fixes * fix: update dependencies * update package lock with npm v7 * fix: mocha tests * lint fixes * fix: double ejs tags * fix: removed extra ejs tag * fix: refactor missing type definition * fix: use proper class variable * fix: import repository always * fix: clean up tests * fix: use proper variable * fix: remove mock builder standalone setup * fix: reactive templates * fix: remove reactive block * fix: reactive modify server open api filter * fix: reactive gateway * fix: more reactive fixes * fix: reactive file generation * fix: no return in save template * fix more reactive test * fix: remove deprecated size configuration * fix row mapper type checks * fix: tests in custom claim converter * fix: custom claim converter test * fix: columnConverter for webflux r2dbc * fix: extra parentheis * fix: null checks * fix: use empty Set instead of null * fix: tests and persistence constructor * fix: add coroutines lib for webflux * fix: add kotlin extensions library * fix: add reactor dependencies for maven * fix: remove mariadb converter issue * fix: webflux build and jdk version * fix: generator unit test * fix: install generator after npm ci * fix: change reactive containers for psql * fix: remove tc in the database url * fix: remove reactive sql tests * chore: remove azure pipelines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringUtils.isEmpty()has been deprecated, so this PR replaces it byObjectUtils.isEmpty()in the constructor ofTokenProvider.Besides, as
isEmpty()is used in a conditional block that is not being tested, I added two unit tests toTokenProviderTest.