Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade angular to v14 #18586

Merged
merged 31 commits into from
Jul 29, 2022
Merged

Upgrade angular to v14 #18586

merged 31 commits into from
Jul 29, 2022

Conversation

mshima
Copy link
Member

@mshima mshima commented May 6, 2022 •
edited by DanielFran
Loading

Fix #18817

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@github-actions github-actions bot added theme: angular theme: dependencies Pull requests that update a dependency file labels May 6, 2022
This was referenced May 12, 2022
Closed
Closed
@mshima
Copy link
Member Author

mshima commented May 12, 2022

Blocked on just-jeb/angular-builders#1205.
Will happen for Angular v14 only.

@mshima mshima changed the title [angular] Bump to jest@28 [angular] Bump to jest@28 and angular to v14 May 12, 2022
@mshima mshima mentioned this pull request May 19, 2022
Closed
@DanielFran DanielFran mentioned this pull request May 26, 2022
Closed
@mshima mshima mentioned this pull request May 26, 2022
Closed
This was referenced Jun 3, 2022
Closed
Closed
Closed
@mshima mshima changed the title [angular] Bump to jest@28 and angular to v14 [angular] upgrade to angular to v14 Jun 3, 2022
@mshima mshima mentioned this pull request Jun 3, 2022
Closed
12 tasks
This was referenced Jun 6, 2022
Closed
Closed
@mraible
Copy link
Contributor

mraible commented Jun 9, 2022 •
edited
Loading

It looks like there's a beta version of @angular-builders/custom-webpack now. just-jeb/angular-builders#1219 (comment)

@DanielFran DanielFran mentioned this pull request Jun 11, 2022
Closed
@DanielFran DanielFran force-pushed the skip_ci-angular_jest28 branch 2 times, most recently from 1c34d92 to d61193f Compare June 13, 2022 19:48
This was referenced Jun 14, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 18, 2022
Closed
Closed
@DanielFran DanielFran mentioned this pull request Jul 21, 2022
Closed
@mraible
Copy link
Contributor

mraible commented Jul 26, 2022

Can you please rebase to fix conflicts, @mshima?

@DanielFran
Copy link
Member

@mshima @mraible Seems that ng-bootstrap will be released today, so I can release a new version soon that will include it

@DanielFran DanielFran marked this pull request as ready for review July 29, 2022 08:24
@DanielFran DanielFran requested a review from qmonmert July 29, 2022 08:25
@DanielFran DanielFran added this to the 7.9.0 milestone Jul 29, 2022
@mshima
Copy link
Member Author

mshima commented Jul 29, 2022

Please squash when merging.

qmonmert
qmonmert approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@qmonmert qmonmert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@DanielFran DanielFran merged commit 08cc714 into main Jul 29, 2022
@DanielFran DanielFran deleted the skip_ci-angular_jest28 branch July 29, 2022 19:30
@DanielFran DanielFran changed the title [angular] upgrade to angular to v14 Upgrade angular to v14 Jul 31, 2022
@mshima
Copy link
Member Author

mshima commented Oct 18, 2022

@DanielFran bounty claimed https://opencollective.com/generator-jhipster/expenses/102422.

@DanielFran
Copy link
Member

@mshima approved

@mshima
Copy link
Member Author

mshima commented Oct 18, 2022

@DanielFran thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tcharl Tcharl Tcharl left review comments

@qmonmert qmonmert qmonmert approved these changes

Assignees
No one assigned
Labels
theme: angular theme: dependencies Pull requests that update a dependency file theme: front theme: jhipster-internals
Projects
None yet
Milestone
7.9.0
Development

Successfully merging this pull request may close these issues.

Upgrade to Angular 14
5 participants
@mshima @mraible @DanielFran @Tcharl @qmonmert