Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow editFile to cascade callbacks. #18934

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

mshima
Copy link
Member

@mshima mshima commented Jun 16, 2022

Allows needles to cascade with file defined by the needle:

insertFooInSpecificFile(generator)(
  insertBar(),
  insertBar2()
)

Old notation needs the file:

generator.editFile(
  'specificFile',
  insertFooInSpecificFile(),
  insertBar(),
  insertBar2()
)

editFile is new so it’s not a breaking change.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima marked this pull request as ready for review June 16, 2022 15:01
@DanielFran DanielFran merged commit 90cf3d5 into jhipster:main Jun 16, 2022
@mshima mshima deleted the skip_ci-edit_file_api branch June 16, 2022 16:34
@DanielFran DanielFran added this to the 7.9.0 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants