Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from proxyquire to @node-loaders/mock #20549

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

mshima
Copy link
Member

@mshima mshima commented Dec 9, 2022

@node-loaders/mock provides esm and commonjs modules mocking support.
This will make the cli transition to esm easier due to existing module mocking usage.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@github-actions github-actions bot added the theme: dependencies Pull requests that update a dependency file label Dec 9, 2022
@mshima mshima mentioned this pull request Dec 9, 2022
6 tasks
@DanielFran DanielFran merged commit bacba2b into jhipster:main Dec 9, 2022
@mshima mshima deleted the skip_ci-mocking branch December 9, 2022 10:09
@Tcharl
Copy link
Contributor

Tcharl commented Dec 9, 2022

I'm not so happy to use jhipster contributors' third party lib as a dependency: I would either prefer to find another alternative (i.e. testdouble) or either embed it in jhipster's monorepo to get maintained by us.
Relying on a one-man-maintained library (without any community behind it), no matter how brilliant the contributor is is usually a very bad idea.
My advice would be to revert this one until there are more contributors on @mshima libs (node-loaders/mock, ...) or a pretty big usage (1K+ like) and to rely on more solid community-provided libs in the meantime (for example finishing https://github.com/jhipster/generator-jhipster/pull/20500/files)

@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants