Fix SystemJS config and Alert Service error #4152
Conversation
|
LGTM 👍 |
|
@sendilkumarn @deepu105 any clues on the error I get? It seems to come from the ngBootstrap lib that doesn't work well with the upgrade adapter :( |
|
@wmarques not yet. ill check later today to see if I can find anything |
|
may be we shouldn't try very hard to make things work with ng1 code as our end goal is to completely move to ng2, so lets focus on making the ng2 part work first |
|
@deepu105 sure but it's a blocking thing as the app doesn't display anymore.. But yes, I agree that if there is some issue with the upgradeadapter it's not a major issue |
| @@ -4,9 +4,7 @@ import { BrowserModule } from '@angular/platform-browser'; | |||
| import { NgModule } from '@angular/core'; | |||
|
|
|||
| // TODO change this to NgbModule --> after complete migration | |||
| import {NgbAlertModule} from '@ng-bootstrap/ng-bootstrap/alert/alert.module'; | |||
There was a problem hiding this comment.
@wmarques the issue you got with datepicker thing is from this check angular/angular#11280
There was a problem hiding this comment.
Im reverting this lines for now
I followed ng-bootstrap docs and changelog to fix the
404 traceur not foundissue, it's fixed. As @deepu105 suggested I commented the import inNotificationInterceptorso it's partially fixed.Now the error I get is
Only selectors matching element names are supported, got: [ngbDatepickerMonthView]from the UpgradeAdapter.