Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ng-jhipster to 0.10.0 #9851

Closed

Conversation

pascalgrimaud
Copy link
Member

Following this PR: #9825


  • Please make sure the below checklist is followed for Pull Requests.

  • Travis tests are green

  • Tests are added where necessary

  • Documentation is added/updated where necessary

  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

@@ -46,7 +46,7 @@
<%_ } _%>
"core-js": "3.1.3",
"moment": "2.24.0",
"ng-jhipster": "0.9.3",
"ng-jhipster": "0.10.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to raise, but, hold my changes as I want to downgrade ng-bootstrap in ng-jhipster to fix warnings during install.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, so let's close this PR. Ping me as soon as you do the PR to ng-jhipster and need a new release. I will be able to do it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@pascalgrimaud pascalgrimaud added this to the 6.1.0 milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants