Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Powered by Google Cloud" footer #345

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Conversation

jdubois
Copy link
Member

@jdubois jdubois commented Feb 11, 2022

Fix #344 as discussed with @alexismp

Here's a screenshot of the result
Screen Shot 2022-02-11 at 15 12 53
:

@pascalgrimaud pascalgrimaud merged commit 1c4d77b into jhipster:main Feb 11, 2022
@pascalgrimaud
Copy link
Member

@jdubois : I can do a release of JHipster Online, so the logo will be displayed. What do you think?

@jdubois
Copy link
Member Author

jdubois commented Feb 11, 2022

@pascalgrimaud hold on, I would like @alexismp to approve first.

@pascalgrimaud
Copy link
Member

Ok, I'll wait your go :)

@jdubois
Copy link
Member Author

jdubois commented Feb 18, 2022

No news from @alexismp but I think it's good, anyway it's already merged and we'll have it on our next release! @alexismp , please ping us if that's an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "Power by GCP" footer
2 participants