reorganize BaseHTTPMiddleware tasks so that app is in the same task as __call__
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecv_stream + http.disconnect in receive fixes encode#1438
Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
…s __call__ This has the following effects: * contextvars set in dispatch are not visible in endpoints * contextvars set in endpoints are visible upstream
jhominal
force-pushed
the
base-http-middleware-fix-contextvars
branch
from
d2aa86f
to
b98d6a1
Compare
That allows context var modifications from dispatch to be visible upstream and downstream.
jhominal
pushed a commit
that referenced
this pull request
Aug 16, 2022
encode#1747) * Explain 'TestClient(app) as client' vs 'client = TestClient(app)' (encode#1733) * Nit (encode#1733) * Update docs/testclient.md (encode#1733) Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com> * Update docs/testclient.md Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com> * Update docs/testclient.md Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com> * Update docs/testclient.md Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com> Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com> Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
jhominal
force-pushed
the
base-http-middleware-no-cancellation
branch
from
1062843
to
4c50738
Compare
jhominal
force-pushed
the
base-http-middleware-no-cancellation
branch
from
4c50738
to
274bdeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is done as support for discussion encode#1729