[BUG] Build issues on Xcode 13 #714
Assignees
Labels
bug
Something isn't working
Comments
|
I am also experiencing the same issue when running My environment: Let me know if I can provide further information. Are there any known workarounds to this issue? |
|
Identical problem My environment: |
|
I just downgraded to 0.0.74 -> 0.0.73. |
|
Fixed in Better Player 0.0.75. |
jhomlala
added
bug
|
This is still not working for me with ^0.0.75. Downgrading to 0.073 (exact version) works though. (iOS simulator) |
|
It fails with a Swift compiler error in the CacheManager file.
|
|
@ObserverMoment I've tried to setup new app with Better Player 0.0.75 with Flutter 2.5.1 and Xcode 13 and iOS 15 and everything's fine. What's your flutter doctor output? What is your xcode version? Can you clean your flutter project and pods before installing BP 0.0.75? |
|
I get the same issue as @ObserverMoment with Better Player 0.0.75, Flutter 2.5.1, Xcode 13 and iOS 15. Better Player 0.0.74 also not working, all builds separated with a flutter clean. |
|
Can you please share full output of build error? Can you please try to setup clean flutter project and add BP 0.0.75 and see if there's error? |
|
@themadmrj Can you look on this on your side? |
|
@jhomlala I currently can't get Xcode 13 and since it works find on Xcode 12, it will have to wait until I can upgrade... |
|
Hi @jhomlala, doctor output: |
|
@jhomlala, and the error log. After doing these steps in the terminal (in vscode)
I get |
|
These lines seem to match the Swift Compiler error I was seeing when building directly inside Xcode. |
If it's just this, than a simple explicit declaration like Storage<String, Data> should fix it. |
|
The same thing with flutter 2.5.1 and better_player 0.0.75 |
I can confirm it's works good for me with an empty flutter project. So i assume the error comes from an incompatibility with one of my others packages? Here my pubspec: Pubspecname: ride_my_park
description: Ride My Park - Riding Map (skateparks, street spots, sessions, events, shops)
publish_to: 'none'
version: 3.0.0+10
environment:
sdk: '>=2.13.0 <3.0.0'
dependencies:
flutter:
sdk: flutter
flutter_localizations:
sdk: flutter
async: ^2.7.0
#icons
icofont_flutter: ^1.3.0
material_design_icons_flutter: ^4.0.5955
font_awesome_flutter: ^9.1.0
#widgets
circular_menu: #^1.1.2
#path: ../circular_menu
git: https://github.com/Milvintsiss/circular_menu
animate_icons: ^2.0.0
shimmer: #2.0.0-nullsafety.0
#path: ../flutter_shimmer
git: https://github.com/Milvintsiss/flutter_shimmer
circular_border_hero: ^0.0.1
better_player: 0.0.75
youtube_player_flutter: ^8.0.0
flutter_svg: ^0.22.0
expandable_page_view: ^1.0.5
#map and location
google_maps_flutter:
git:
url: https://github.com/Milvintsiss/plugins.git
ref: localdev
path: packages/google_maps_flutter/google_maps_flutter
location: ^4.3.0
map_launcher: ^2.1.1
#firebase
firebase_core: ^1.6.0
firebase_crashlytics: ^2.2.1
#api requests
dio: ^4.0.0
#others
version_tracker: ^2.1.1
new_version: ^0.2.2
pub_semver: ^2.0.0
device_info_plus: ^2.1.0
rive: ^0.7.22
in_app_review: ^2.0.2
url_launcher: ^6.0.3
flutter_inappwebview: ^5.3.2
cached_network_image: ^3.0.0
shared_preferences: ^2.0.7
timezone: ^0.7.0
add_2_calendar: ^2.1.0
dev_dependencies:
dart_code_metrics: ^4.3.1
flutter:
uses-material-design: true
assets:
[...]My log is the same as @ObserverMoment except warnings related to my project |
|
same issue after upgrade from 0.0.73 to 0.0.75 ...flutter/.pub-cache/hosted/pub.dartlang.org/better_player-0.0.75/ios/Classes/CacheManager.swift:33:40: error: generic parameter 'Key' [✓] Flutter (Channel stable, 2.5.1, on macOS 11.2.3 20D91 darwin-x64, locale en-FR) • No issues found! any update please ? |
|
I still can't reproduce this issue on my side. Anyway I'm trying to fix blindly this issue. Please use this temporary BP version: better_player:
git:
url: https://github.com/jhomlala/betterplayer
ref: feature/ios_crash_fixAlso please do these steps:
@Milvintsiss thank you for adding your pubspec. Anyway it didn't trigger any issue on my side (I just needed to set iOS version 10). |
|
I tried with your branch but it's not working too. |
I did it (with dependency_overrides) and got a new error: I don't use better_player in my project directly, but some of packages use it, I think that's tweet_ui and they also have an issue with flutter 2.5: schibsted/tweet_ui#69 |
|
I have applied new fix to branch
|
Closed
|
I've added to pubspec.yaml the following. And performed |
|
@prilepskiy, still failing after |
|
Does this problem appears on clean fresh project? |
|
I believe this issue is connected with existing projects. On the new fresh project, only iOS version must be changed to 11 in deployment info. |
|
If your problem still occurs after clearing cache please provide reproducible example. This is the only way to help you solving issue in your project. Downgrading to 0.0.73 is only temp. solution because you won't receive future updates for BP. |
|
Hi @jhomlala. This is a pretty new project - first commit was only 7 days a go and it was a fresh install of the latest Flutter version (2.5.1). Will check the links above and let you know if anything works. |
|
After completing these steps the build still fails.
|
|
Do we have a theory for why 0.073 works but later versions do not? This may help me focus in on the actual issue. |
|
Just made a fresh install with only BP in the pubspec and |
|
In version 0.0.74 (https://github.com/jhomlala/betterplayer/releases/tag/0.0.74) we have introduced caching solution for iOS. For HLS data sources we're using https://github.com/StyleShare/HLSCachingReverseProxyServer which uses PINCache. Probably some other dependency from your app collides with Better Player. Can you try adding one by one libraries to see which collide with BP? Fresh installation may work fine because there's no other library which collide. |
|
Finally go to the bottom of this one, ...I think. I had added these lines to my podfile - they were needed when I first set this project up last week due to some pods not having been updated to target greater than iOS 8.0. Removing them - and then doing all the cache clearing / cleaning possible - then restarting vscode - has worked. I can only assume that whichever packages were causing the original issue which required this fix above have now updated their pod dependencies to work without it. But somehow this line was causing an issue? Thanks for your time in troubleshooting this one - hopefully this solution will help others as this podfile fix is on stack and may be out there causing issues. |
|
Great to hear that it has been fixed on your project. |
@ObserverMoment @jhomlala build still failed for me :( I have this at the end of my Podfie ( I have not update this file since 1 year ) platform :ios, '12.0' what I should do ? should I remove this ? can you please provide the exact procedure / command to upgrade this package from 0.0.73 to 0.0.76 |
|
Try removing
target.build_configurations.each do |config|
config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '12.0'
end
For flutter 2.5 this manual fix for iOS pod targets was what caused the
issue, for my setup anyway.
…On Fri, 1 Oct 2021 at 20:04, azazadev ***@***.***> wrote:
Finally go to the bottom of this one, ...I think.
target.build_configurations.each do |config|
config.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET'
end
I had added these lines to my podfile - they were needed when I first set
this project up last week due to some pods not having been updated to
target greater than iOS 8.0. Removing them - and then doing all the cache
clearing / cleaning possible - then restarting vscode - has worked.
I can only assume that whichever packages were causing the original issue
which required this fix above have now updated their pod dependencies to
work without it. But somehow this line was causing an issue?
Thanks for your time in troubleshooting this one - hopefully this solution
will help others as this podfile fix is on stack and may be out there
causing issues.
Finally go to the bottom of this one, ...I think.
target.build_configurations.each do |config|
config.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET'
end
I had added these lines to my podfile - they were needed when I first set
this project up last week due to some pods not having been updated to
target greater than iOS 8.0. Removing them - and then doing all the cache
clearing / cleaning possible - then restarting vscode - has worked.
I can only assume that whichever packages were causing the original issue
which required this fix above have now updated their pod dependencies to
work without it. But somehow this line was causing an issue?
Thanks for your time in troubleshooting this one - hopefully this solution
will help others as this podfile fix is on stack and may be out there
causing issues.
@ObserverMoment <https://github.com/ObserverMoment> @jhomlala
<https://github.com/jhomlala> build still failed for me :(
I have this at the end of my Podfie ( I have not update this file since 1
year )
platform :ios, '12.0'
...
...
...
post_install do |installer|
installer.pods_project.targets.each do |target|
flutter_additional_ios_build_settings(target)
target.build_configurations.each do |config|
config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '12.0'
end
end
end
what I should do ? should I remove this ? can you please provide the exact
procedure / command to upgrade this package from 0.0.73 to 0.0.76
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#714 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5FDKXPMMZPRM5SBXKCHQTUEYA45ANCNFSM5EN4B6NQ>
.
|
|
Removing this hardcoded iOS version for each target should fix issue. Usually you just need to to update iOS version to 11 and that's all. |
|
Thanks @ObserverMoment @jhomlala, working after updating my Podfile with @ObserverMoment suggestion |
Closed
twogood
added a commit
to activout/betterplayer
that referenced
this issue
Nov 3, 2021
Trying to fix part of jhomlala#714
This was referenced Nov 3, 2021
|
@ObserverMoment see #787 :) |
jhomlala
added a commit
that referenced
this issue
Dec 29, 2021
* Updated dependencies * Fix bug where a render error can occur if the width of the player is less than 240 pixels. (#810) * Updated changelog * Switch from jcenter to mavenCentral (#798) * Updated changelog * Fixed badState error (#796) * Add dependencies on GCDWebServer and PINCache (#787) Trying to fix part of #714 * Updated changelog * Lint & format changes * Updated installation documentation page * Updated installation documentation page * Updated installation documentation page Co-authored-by: Alan <adman1108@gmail.com> Co-authored-by: Peter Majchrak <pm@lix.com> Co-authored-by: masoudk2000 <52602761+masoudk2000@users.noreply.github.com> Co-authored-by: David Eriksson <david@activout.se>
jhomlala
added a commit
that referenced
this issue
Dec 29, 2021
* Updated dependencies * Fix bug where a render error can occur if the width of the player is less than 240 pixels. (#810) * Updated changelog * Switch from jcenter to mavenCentral (#798) * Updated changelog * Fixed badState error (#796) * Add dependencies on GCDWebServer and PINCache (#787) Trying to fix part of #714 * Updated changelog * Lint & format changes * Updated installation documentation page * Updated installation documentation page * Updated installation documentation page * Fixed full screen button padding in material controls. * Added setBetterPlayerControlsConfiguration method * Added `setOverriddenFit` in `BetterPlayerController`. * Added `setOverriddenFit` in `BetterPlayerController`. * General refactor * Format Co-authored-by: Alan <adman1108@gmail.com> Co-authored-by: Peter Majchrak <pm@lix.com> Co-authored-by: masoudk2000 <52602761+masoudk2000@users.noreply.github.com> Co-authored-by: David Eriksson <david@activout.se>
geriby23
pushed a commit
to threadable/betterplayer
that referenced
this issue
Jul 16, 2024
* Updated dependencies * Fix bug where a render error can occur if the width of the player is less than 240 pixels. (jhomlala#810) * Updated changelog * Switch from jcenter to mavenCentral (jhomlala#798) * Updated changelog * Fixed badState error (jhomlala#796) * Add dependencies on GCDWebServer and PINCache (jhomlala#787) Trying to fix part of jhomlala#714 * Updated changelog * Lint & format changes * Updated installation documentation page * Updated installation documentation page * Updated installation documentation page Co-authored-by: Alan <adman1108@gmail.com> Co-authored-by: Peter Majchrak <pm@lix.com> Co-authored-by: masoudk2000 <52602761+masoudk2000@users.noreply.github.com> Co-authored-by: David Eriksson <david@activout.se>
geriby23
pushed a commit
to threadable/betterplayer
that referenced
this issue
Jul 16, 2024
* Updated dependencies * Fix bug where a render error can occur if the width of the player is less than 240 pixels. (jhomlala#810) * Updated changelog * Switch from jcenter to mavenCentral (jhomlala#798) * Updated changelog * Fixed badState error (jhomlala#796) * Add dependencies on GCDWebServer and PINCache (jhomlala#787) Trying to fix part of jhomlala#714 * Updated changelog * Lint & format changes * Updated installation documentation page * Updated installation documentation page * Updated installation documentation page * Fixed full screen button padding in material controls. * Added setBetterPlayerControlsConfiguration method * Added `setOverriddenFit` in `BetterPlayerController`. * Added `setOverriddenFit` in `BetterPlayerController`. * General refactor * Format Co-authored-by: Alan <adman1108@gmail.com> Co-authored-by: Peter Majchrak <pm@lix.com> Co-authored-by: masoudk2000 <52602761+masoudk2000@users.noreply.github.com> Co-authored-by: David Eriksson <david@activout.se>
SreyMochOrng
pushed a commit
to SreyMochOrng/resolve_better_player
that referenced
this issue
Jul 17, 2024
* Updated dependencies * Fix bug where a render error can occur if the width of the player is less than 240 pixels. (#810) * Updated changelog * Switch from jcenter to mavenCentral (#798) * Updated changelog * Fixed badState error (#796) * Add dependencies on GCDWebServer and PINCache (#787) Trying to fix part of jhomlala/betterplayer#714 * Updated changelog * Lint & format changes * Updated installation documentation page * Updated installation documentation page * Updated installation documentation page Co-authored-by: Alan <adman1108@gmail.com> Co-authored-by: Peter Majchrak <pm@lix.com> Co-authored-by: masoudk2000 <52602761+masoudk2000@users.noreply.github.com> Co-authored-by: David Eriksson <david@activout.se>
SreyMochOrng
pushed a commit
to SreyMochOrng/resolve_better_player
that referenced
this issue
Jul 17, 2024
* Updated dependencies * Fix bug where a render error can occur if the width of the player is less than 240 pixels. (#810) * Updated changelog * Switch from jcenter to mavenCentral (#798) * Updated changelog * Fixed badState error (#796) * Add dependencies on GCDWebServer and PINCache (#787) Trying to fix part of jhomlala/betterplayer#714 * Updated changelog * Lint & format changes * Updated installation documentation page * Updated installation documentation page * Updated installation documentation page * Fixed full screen button padding in material controls. * Added setBetterPlayerControlsConfiguration method * Added `setOverriddenFit` in `BetterPlayerController`. * Added `setOverriddenFit` in `BetterPlayerController`. * General refactor * Format Co-authored-by: Alan <adman1108@gmail.com> Co-authored-by: Peter Majchrak <pm@lix.com> Co-authored-by: masoudk2000 <52602761+masoudk2000@users.noreply.github.com> Co-authored-by: David Eriksson <david@activout.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
for 'startDataRequest(with:)' (at /Users/xyz/Development/flutter/.pub-cache/hosted/pub.dartlang.org/better_player-0.0.74/ios/Classes/CachingPlayerItem.swift:66:9)
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var
LLVM_SYMBOLIZER_PATHto point to it):0 swift-frontend 0x000000010b6e76f7 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 39
1 swift-frontend 0x000000010b6e6688 llvm::sys::RunSignalHandlers() + 248
2 swift-frontend 0x000000010b6e7d06 SignalHandler(int) + 278
3 libsystem_platform.dylib 0x00007fff204afd7d _sigtramp + 29
4 libsystem_platform.dylib 0x00007ffee94c5310 _sigtramp + 18446744072786892208
5 swift-frontend 0x00000001071f7e47 (anonymous namespace)::PredictableDeadAllocationElimination::run() + 6855
6 swift-frontend 0x00000001072247b9 swift::SILPassManager::runFunctionPasses(unsigned int, unsigned int) + 4409
7 swift-frontend 0x000000010722092b swift::SILPassManager::executePassPipelinePlan(swift::SILPassPipelinePlan const&) + 155
8 swift-frontend 0x000000010723b20c swift::SimpleRequest<swift::ExecuteSILPipelineRequest, std::__1::tuple<> (swift::SILPipelineExecutionDescriptor), (swift::RequestFlags)1>::evaluateRequest(swift::ExecuteSILPipelineRequest const&, swift::Evaluator&) + 60
9 swift-frontend 0x0000000107229005 llvm::Expectedswift::ExecuteSILPipelineRequest::OutputType swift::Evaluator::getResultUncachedswift::ExecuteSILPipelineRequest(swift::ExecuteSILPipelineRequest const&) + 469
10 swift-frontend 0x000000010722b3bb swift::runSILDiagnosticPasses(swift::SILModule&) + 187
11 swift-frontend 0x00000001069746de swift::CompilerInstance::performSILProcessing(swift::SILModule*) + 62
12 swift-frontend 0x000000010681fd59 performCompileStepsPostSILGen(swift::CompilerInstance&, std::__1::unique_ptr<swift::SILModule, std::__1::default_deleteswift::SILModule >, llvm::PointerUnion<swift::ModuleDecl*, swift::SourceFile*>, swift::PrimarySpecificPaths const&, int&, swift::FrontendObserver*) + 1161
13 swift-frontend 0x0000000106811d46 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 13494
14 swift-frontend 0x0000000106753a48 main + 1032
15 libdyld.dylib 0x00007fff20485f3d start + 1
error: Segmentation fault: 11 (in target 'better_player' from project 'Pods')
The text was updated successfully, but these errors were encountered: