Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint for getting account balance #10

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

shaymdev
Copy link
Contributor

@shaymdev shaymdev commented Mar 27, 2024

It's likely that an integrating application would want to display account balances.

This pull request adds a new endpoint that, given an account id, returns an account balance.

The query used was taken from ActualBudgets source

@shaymdev shaymdev marked this pull request as ready for review March 27, 2024 23:11
@jhonderson
Copy link
Owner

Thanks for contributing to the project.

Although I haven’t tested this change, everything looks good to me. The only thing I am not sure about it’s what happen when the account balance is 0, looking at the code it looks like it will throw an error, which wouldn’t be ok.

Did you have a chance to test this new endpoint locally ? If so feel free to add few curl commands and results for few scenarios, and I am happy to merge. Otherwise I will test and merge on the weekend.

Thanks again

@jhonderson jhonderson merged commit 0233242 into jhonderson:main Apr 5, 2024
1 check failed
@jhonderson
Copy link
Owner

Tested locally and everything works, thanks!

@shaymdev
Copy link
Contributor Author

shaymdev commented Apr 8, 2024

Thanks for following up on that! I had wanted to get back to doing some of the more formal testing myself but we were out of town for the week and you beat me to it!

@shaymdev shaymdev deleted the shaymdev-getAccountBalance branch April 8, 2024 15:49
@jhonderson jhonderson mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants