Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final PV not always being shown #9

Closed
jhonnold opened this issue Aug 27, 2021 · 1 comment · Fixed by #12
Closed

Final PV not always being shown #9

jhonnold opened this issue Aug 27, 2021 · 1 comment · Fixed by #12
Assignees
@jhonnold
Labels
bug Something isn't working

Comments

@jhonnold
Copy link
Owner

The final pv of an engine is usually not printed for users to see.
@jhonnold jhonnold added the bug Something isn't working label Aug 27, 2021
@jhonnold jhonnold self-assigned this Aug 27, 2021
@jhonnold
Copy link
Owner Author

Seems to be an issue of both UI refusing to update the PV if not STM and final PV being received after the move has been delivered.

jhonnold added a commit that referenced this issue Aug 27, 2021
@jhonnold
Parse PV even after "bestmove" has been received
f5c4965 
Fixes #9. 

Issue was the result of the bestmove being received before the final PV. This would cause the PV to no longer be parseable. This is resolved by making a PGN copy of the board, and undoing the last move if the PV is for the wrong side. 

Along with this, a single move number was being stored which caused PV updates after a move was made to report the wrong move number. These values are now tracked on a per-color basis to prevent this issue as well.
@jhonnold jhonnold mentioned this issue Aug 27, 2021
Merged
jhonnold added a commit that referenced this issue Aug 27, 2021
@jhonnold
Parse PV even after "bestmove" has been received (#12)
f2cdd3c 
Fixes #9. 

Issue was the result of the bestmove being received before the final PV. This would cause the PV to no longer be parseable. This is resolved by making a PGN copy of the board, and undoing the last move if the PV is for the wrong side. 

Along with this, a single move number was being stored which caused PV updates after a move was made to report the wrong move number. These values are now tracked on a per-color basis to prevent this issue as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhonnold jhonnold

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parse PV even after "bestmove" has been received jhonnold/node-tlcv
1 participant
@jhonnold