Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for globby to include directories #18

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

KasparEtter
Copy link
Contributor

Thanks a lot for the --ignore-directories option! As it turned out, after upgrading globby from 6.1.0 to 11.0.0, directories are already ignored by default by globby since 7.0.0:

The nodir option is now also true by default. This means that by default it will now only return file paths, not directory paths.

I figured this out after discovering that the --ignore-directories option had no effect and then debugging your tool locally because I couldn't figure out how your commit would have changed that. It seems that the option nodir no longer exists (thanks to the TypeScript compiler in Visual Studio Code I already had an error before even trying 🎉) and onlyFiles is the right option to use.

Strictly speaking, your 6.1.0 release had thus a breaking change and should have been tagged 7.0.0. While this issue was quite subtle, it would be nice to have unit tests to catch regressions like this. But overall I really like this tool so I stop complaining! 🤭 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants