Add option for globby to include directories #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot for the
--ignore-directories
option! As it turned out, after upgradingglobby
from6.1.0
to11.0.0
, directories are already ignored by default byglobby
since7.0.0
:I figured this out after discovering that the
--ignore-directories
option had no effect and then debugging your tool locally because I couldn't figure out how your commit would have changed that. It seems that the optionnodir
no longer exists (thanks to the TypeScript compiler in Visual Studio Code I already had an error before even trying 🎉) andonlyFiles
is the right option to use.Strictly speaking, your 6.1.0 release had thus a breaking change and should have been tagged 7.0.0. While this issue was quite subtle, it would be nice to have unit tests to catch regressions like this. But overall I really like this tool so I stop complaining! 🤭 🤓