Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use modern C++ to determine header conversion automatically #18

Closed
adeguet1 opened this issue Oct 26, 2022 · 0 comments
Closed

Use modern C++ to determine header conversion automatically #18

adeguet1 opened this issue Oct 26, 2022 · 0 comments
Assignees
@adeguet1
Labels
enhancement

Comments

@adeguet1
Copy link
Contributor

Based on @brendanburkhart pull request, we should use modern C++ to automatically determine how to convert the header part of cisst and ROS data types. In general, cisst potentially has:

  • timestamp
  • valid flag
  • reference frame
  • moving frame
    ROS potentially has:
  • header/timestamp
  • header/frame_id
  • child_id
    Since the conversion for these fields can be performed automatically, it should be done outside mtsROSToCISST and mtsCISSTToROS. Note that the mtsCISSTToROS should return a boolean based or the value of IsValid or absence of method IsValid. Once implemented, this approach should be ported to the ROS 2 bridge.
@adeguet1 adeguet1 self-assigned this Oct 26, 2022
@adeguet1 adeguet1 linked a pull request Oct 26, 2022 that will close this issue
Add ROS header frame_id to cisst data #16
Closed
adeguet1 added a commit that referenced this issue Oct 26, 2022
@adeguet1
mtsROSToCISST: created separate conversion method to handle the cisst…
9f23504 
… and ROS headers automatically at compilation time (issue #18)
adeguet1 added a commit that referenced this issue Oct 31, 2022
@adeguet1
mtsCISSTToROS: updated for #18, compile time choice for header conver…
e43a30a 
…sion
adeguet1 added a commit that referenced this issue Nov 7, 2022
@adeguet1
Feature automated header (#19)
3444b9d 
* mtsROSToCISST: created separate conversion method to handle the cisst and ROS headers automatically at compilation time (issue #18)

* mtsROSToCISST header: added case for child_frame_id to MovingFrame

* mtsCISSTToROS: updated for #18, compile time choice for header conversion
@adeguet1 adeguet1 mentioned this issue May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adeguet1 adeguet1

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ROS header frame_id to cisst data brendanburkhart/cisst-ros
1 participant
@adeguet1