Pin testcafe image in run scripts #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Did you mean to skip the 21-nightly tests? |
bseeger
approved these changes
Jan 4, 2022
|
DonRichards
added a commit
that referenced
this pull request
Oct 14, 2022
…sed-issue Makefile: Abstract how we call sed, for compatibility with both Linux…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumb way of pinning the version of Testcafe that runs tests. Uses a new ENV variable that can be shared across the various test scripts, but does not necessarily use the version of Testcafe defined in the docker-compose files.
With this change, tests should now pass in CI. Test logs will also now show that
v1.17.1of Testcafe is used, instead oftestcafe:lastest