Fix LED on/off switch at devices with dimming support #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested at FRITZ!Box 7530 with FRITZ!OS 07.27
jhubig
approved these changes
Nov 28, 2021
jhubig
approved these changes
Nov 28, 2021
|
@killerbees19 Sorry for my late response. Thanks a lot for that. I just needed to commit that, because the switching on/off of LEDs didn't work anymore for me with the current FritzOS 07.29. Maybe also didn't work for a long time already. On which OS are you currently? Could you maybe check if it is still working for you? Thx. Something else related to the brightness. Unfortunately I cannot test it with my FritzBox 7490. Do you maybe know the possible values for dimValue? I guess on your FritzBox 7530 the dimming is also not available, or? Thanks. Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Tested at FRITZ!Box 7530 with FRITZ!OS 07.27)
!!! THIS NEEDS FURTHER TESTING AT OTHER DEVICES AND/OR WITH OLDER FRITZ!OS RELEASES !!!
Feedback welcome 😍