Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging #3

Closed
wants to merge 3 commits into from
Closed

Logging #3

wants to merge 3 commits into from

Conversation

DrPennybags
Copy link
Contributor

I added support for logging.
--logging wperf.log

--logging "{name of log file}"
if --logging is only specified then the default wperf.log will be used
@jhuckaby
Copy link
Owner

jhuckaby commented Sep 4, 2019

Thanks, but I didn't implement this because the pixl-cli setLogFile() thing adds a date/time stamp to every line, and this really messes with the output of wperf. The tables and histogram look like garbage. What you can do is can simply redirect the wperf output to a file. This automatically suppresses the progress bar, and everything looks correct. Example:

wperf http://github.com --max 10 > foo.txt

I will, however, implement your fix for the null check on resp, and credit you on the commit. Thank you for catching that bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants