Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Nullability assertions to jspecify #2048

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Migrate Nullability assertions to jspecify #2048

merged 1 commit into from
Nov 10, 2023

Conversation

jhy
Copy link
Owner

@jhy jhy commented Nov 10, 2023 •
edited
Loading

Away from jsr305

With the goal of having a nullability assertion annotation that supports Java modules, so we can release the next version of jsoup.

Annotation options appear limited and does not support @​WillClose, but rest appears OK.

Fixes #2028
Fixes #1992

Related: #1616

@jhy
Migrate Nullability assertions to jspecify
9563dac 
Away from jsr305

With the goal of having a nullability assertion annotation that supports Java modules, so we can release the next version of jsoup.

Annotation options appear limited and does not support @​WillClose, but rest appears OK.

Will fix #2028, #1992
@jhy jhy merged commit d11450c into master Nov 10, 2023
12 checks passed
@jhy jhy deleted the jspecify branch November 10, 2023 21:43
@jhy jhy added this to the 1.17.1 milestone Nov 10, 2023
@jhy jhy self-assigned this Nov 10, 2023
@jhy jhy mentioned this pull request Nov 10, 2023
Merged
@jhy
Copy link
Owner Author

jhy commented Nov 12, 2023 •
edited
Loading

For reference (as noted in #2028):

To get jspecify nullability warnings to show in IntelliJ:

Settings -> Editor -> Inspections -> Probable bugs -> Nullability Problems -> @​NotNull/ @​Nullable problems:
Configure Annotations (button on right hand pane; I had to drag the horizonal hair-line up to get it to be visible)
Add org.jspecify.annotations.Nullable to the Nullable tab.
And org.jspecify.annotations.NullMarked and org.jspecify.annotations.NonNull to the Not Null tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhy jhy

Labels
None yet
Projects
None yet
Milestone
1.17.1
Development

Successfully merging this pull request may close these issues.

Migrate to module-supported Nullable annotation package FR: Strict Nullability?
1 participant
@jhy