Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Validation of cookie names in HttpConnection #377

Merged
merged 1 commit into from
Oct 2, 2014
Merged

Fix Validation of cookie names in HttpConnection #377

merged 1 commit into from
Oct 2, 2014

Conversation

kaznovac
Copy link

@kaznovac kaznovac commented Dec 5, 2013

cookie name validation is inconsistent

  • getting the cookie by name uses notNull check while setting it requires notEmpty (a stronger constraint)
  • hasCookie and deleteCookie validate constant strings instead of passed cookie name

jhy added a commit that referenced this pull request Oct 2, 2014
@jhy
Merge pull request #377 from kaznovac/master
333a646 
Fix Validation of cookie names in HttpConnection
@jhy jhy merged commit 333a646 into jhy:master Oct 2, 2014
jhy added a commit that referenced this pull request Oct 2, 2014
@jhy
Pull changelog
ebf35bb 
Fixes #377
@jhy
Copy link
Owner

jhy commented Oct 2, 2014

Thanks!

zazi pushed a commit to dswarm/jsoup that referenced this pull request Oct 15, 2015
@jhy @zazi
Pull changelog
f314681 
Fixes jhy#377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaznovac @jhy