Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The value of theta is different from the paper #1

Closed
ZiangYan opened this issue Jun 25, 2019 · 2 comments
Closed

The value of theta is different from the paper #1

ZiangYan opened this issue Jun 25, 2019 · 2 comments

Comments

@ZiangYan
Copy link

Hi Jianbo,

Thanks for your nice work, and it's experimental results are really impressive.

I notice the values of theta are actually different in paper and source code. From equation 17 in the paper, theta should be 0.001 * d^{-3/2} under the l2 constriant. However, in the source code, theta is set to 1 * d^{-3/2} in this newer commit or 0.01 * d^{-1/2} in this older commit

@Jianbo-Lab
Copy link
Owner

Hi @ZiangYan,

Thanks for the catch! That is a typo in my paper.

Initially theta = 0.01 * d^{-1/2} was used for all the experiments. In the current version of the preprint, we added an improved version of Theorem 2, which explicitly suggests the choice of delta as a function of d. Thus, we redefine theta = 1 * d^{-3/2}.

However, somehow I forgot to change 0.001 to 1. Please use the choice of theta in the new commit as the default one. I will update theta in the future version of preprint.

@ZiangYan
Copy link
Author

ZiangYan commented Jul 4, 2019

Thanks @Jianbo-Lab !

This really clarifies and helps me a lot.

@ZiangYan ZiangYan closed this as completed Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants