Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MUI, CRA, React, and Monaco. #7

Merged
merged 6 commits into from
Oct 19, 2022
Merged

Upgrade MUI, CRA, React, and Monaco. #7

merged 6 commits into from
Oct 19, 2022

Conversation

jichu4n
Copy link
Owner

@jichu4n jichu4n commented Oct 19, 2022

This PR upgrades key package dependencies to their latest versions, including:

  • Material UI v4 -> v5
  • Create React App v4 -> v5 (including Webpack v4 -> v5)
  • React v17 -> v18
  • Monaco v30 -> v34

These upgrades (in particular MUI and CRA) are non-trivial due to breaking backwards compatibility, requiring broad code changes.

Additional notes:

* The dropzone feature is still TODO as the current library does not support
  MUI v5.

* Updated qbjc to use iconv-lite instead of singlebyte which is
  deprecated.
This is now possible due to upgrades to react-scripts.
Also sets default page background to dark to prevent "white flash"
during intial page load.
@jichu4n jichu4n merged commit 52214d4 into master Oct 19, 2022
@jichu4n jichu4n deleted the mui5 branch October 19, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant