Fix build on Fedora, openSuse etc. - use sys/xattr.h instead of attr/xattr.h #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapitainsky
changed the title
|
ENOATTR is always supposed to be equal to ENOATTR ? |
I have tried get the broader compatibility as sys/errno.h return ENODATA, while ENOATTR is not defined: Linux |
|
If I understand well, if I want to compile on FreeBSD, I'll have #ifdef and adapt this include of xattr.h and the #define. Am I correct ? |
|
Yes but I do not have FreeBSD to test now
… On 28 Jun 2022, at 16:03, jief666 ***@***.***> wrote:
If I understand well, if I want to compile on FreeBSD, I'll have #ifdef and adapt this include of xattr.h and the #define. Am I correct ?
—
Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADXJHOTVDDC5JUQCZHZIDRLVRMH3ZANCNFSM52CNDFEQ>.
You are receiving this because you authored the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on #8
Applications should use sys/xattr.h instead of attr/xattr.h which is missing in many distros (Redhat, Fedora, openSuse, Centos) and existing source code will not compile.
Proposed change should work on all distros - tested on Debian, Fedora and openSuse