Refactor BoundColumn attributes to allow override of class names. #349 #367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #349
First proposal, refactoring the BoundColumn code to allow override of the class names. For now this preserves the old behaviour of adding the column's name by default. See the test for how it can be overriddden. In a future version we could just swap the two
get_class_name
versions.I'm not entirely happy with this, though. I think it would be better if users didn't have to touch the BoundColumn internals. I just couldn't think of a better place.
Maybe instead have a overridable
get_column_class_name(self, bound_column)
method directly on the table which would be called from BoundColumn, passing itself?