Write colorbrewer palettes to .py file and remove setuptools dependency #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable, thanks! |
|
Great, thanks! |
|
This has been released in version 3.3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading palettable requires loading setuptools, which is 2.8 MB, and also may not be installed on all systems. This is causing a nontrivial performance penalty for my application because I'm loading palettable on Pyodide (Python compiled to WebAssembly, running in the browser).
This PR removes the dependency on setuptools. Instead of serializing the colorbrewer data to JSON, it saves the data directly as Python code in a .py file. The JSON code is also valid Python code for creating nested dictionaries and lists. I made the change by basically renaming the .json file to .py, and storing the result in a variable.
With this change, there's no need for setuptools, so loading palettable should be faster.