Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added remote and help flag #7

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Added remote and help flag #7

merged 2 commits into from
Aug 8, 2022

Conversation

hi2gage
Copy link
Contributor

@hi2gage hi2gage commented Aug 4, 2022

Added remote flag for better usability and help flag so that the user is able to see all of the fun things they can do with git-checkout-interactive-rust.

There might be a better way to handle arguments in get_branches() function.

src/main.rs Outdated Show resolved Hide resolved
@hi2gage hi2gage requested a review from jiito August 5, 2022 04:55
Copy link
Owner

@jiito jiito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should eventually find some way to reduce the code reuse out of these two functions but make it so there is no boolean flag passed in. Possibly this is just a wrapper for the library function that passes in the git2::BanchType for the flag.

@jiito
Copy link
Owner

jiito commented Aug 8, 2022

@hi2gage please leave a comment so that I know you have learned something from this experience.

@jiito jiito merged commit 5cec131 into jiito:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants