-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Abide With Me" with additional verses #18
Comments
Worked on Issue #18 ; to follow common practice and did a bit of cleanup.
An extra separator character was still there in Abide With Me slides. Issue #18
Issue #18 - Updated the readme with the results of research of Abide With Me.
@Ibab642 and @crazycub212 : Please review my research on adding verses to Abide With Me and let me know what you think. My recommendation is contained in the README.md file. The research is in the abide_with_me/README.md |
I definitely agree with the inclusion of the verses in general, and the On Mon, Oct 31, 2016 at 2:46 PM, Jim Duke notifications@github.com wrote:
|
Posted the built files for Abide With Me in preparation for the technical review.
@Ibab642 - Please review my research on adding verses to Abide With Me and let me know what you think. My recommendation is contained in the README.md file. Please post the results of your review in a comment to the issue. You can do that by simply replying to the automatic email you should receive. Or you can add a comment to the issue directly here. The research is in the abide_with_me/README.md |
I love the words of this song but it has taken me some time to think of On Nov 18, 2016 11:33 AM, "Jim Duke" notifications@github.com wrote:
|
I used the following rubric for the review:
My Review:
|
Slide observation: Using Two scripture verses on the title page looks odd, particularly because the same amount of space separates the verse in Luke from the non-quoted portion of 1 Cor. - perhaps reduce the spacing between the two portions of 1 Cor. to closer associate these two on the slide. |
For Issue #18; Thickened staff lines on the slides. Added a 6th verse. Corrected capitalization and punctuation. Added individual part MIDI's. Adjusted spacing on verses quoted on title page for the slides.
Updated all the review materials for Abide with Me (Issue #18). This includes MP3 files now.
Made several changes to address the problems found in the reviews. I also updated the README.md file to include an additional source (scans of a hymnal from 1880 with all the original verses); as well as to revise the recommendation to use the verses from this source. Changes include:
To answer @pianoman5001 on Titles on slides. Yes, we will only include the title of the song on the Title slide for the song. This gave use more room for the music and eliminated several problems that were occurring on songs with longer titles. The review materials have been updated. But be sure to also consult the updated README.md. |
Posted on behalf of @timcaldwell |
Changes in response to @timcaldwell 's comments:
|
Thanks for checking.
…----
Tim Caldwell
Sent from my iPhone
On Dec 27, 2016, at 2:11 AM, Jim Duke ***@***.***> wrote:
Changes in response to @timcaldwell 's comments:
1st System: the period after "hour" was already changed to a colon based upon some older source versions. I believe the colon makes more sense than the semicolon based upon what I think was intended by the verse.
2nd System: I confirmed that the chord in the 3rd measure is correct; I had already added a comma after "Lord", and had changed the period to an exclamation point. Prefer using the exclamation point, particularly given the use of them in many other places where the thought of God abiding with me uses an exclamation point.
3rd System: After examining about 60 hymnals (hymnary is great), about half put commas in "Who, like Thyself, my guide"; about half didn't. Slightly more favored leaving them out. However, when singing that passage I greatly prefer the commas in place. They really aide the meaning of that phrase I think. The semicolon after see vs a dash. After examining at least 100 hymns - only one used a dash. Most of the others used a semicolon, with the use of a colon a distant 2nd, and the use of a period even less common. I prefer keeping the semicolon.
4th System: The rest of the song uses the simple spelling "O" instead of "Oh". And in examining many other hymnals the use of "O" is by far the most common spelling. All the ending words now end with an exclamation point.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I think this song is good. The only comment would be about the combining of voices but I don't think it's much of an issue for this song. I think this issue can be closed. |
I'm reluctant to make the slides different from the sheet music. I've opened an issue to combine parts on all the songs where voices share a staff (Issue #34) |
Put the song Abide with Me through the standard process. Typeset it in Lilypond and publish the results.
The text was updated successfully, but these errors were encountered: