Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties to versions #138

Closed
jimporter opened this issue Mar 3, 2023 · 2 comments
Closed

Add properties to versions #138

jimporter opened this issue Mar 3, 2023 · 2 comments
Milestone

Comments

@jimporter
Copy link
Owner

This would be a dictionary of key/value pairs for each version with no built-in meaning in mike, but which can be used by themes or other tools to do fancy things.

@AdrianoKF
Copy link

After you pointed out you'd be open to contributions towards 2.0 in issue #180 (sorry for the duplicate), I'm happy to work on this issue, if you're interested.

From an implementation perspective, this seems relatively straightforward - I guess the question is about user ergonomics on the CLI. I would propose a signature like mike deploy --prop FOO=1 --prop BAR=42 [...] VERSION, where the user can pass the same option an arbitrary number of times (similar to --env in Docker). Alternatively, if more complex properties are interesting to the user, maybe allowing the props directly in JSON format (e.g., --props-json as a CLI arg, or --props-file to enable reading from a file).

@jimporter
Copy link
Owner Author

This is actually about 75% done on a branch already, but thanks for the offer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants