Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver dialect for Snowflake #14

Closed
wants to merge 3 commits into from

Conversation

hundredwatt
Copy link

@hundredwatt hundredwatt commented Jun 29, 2020

*gosnowflake.SnowflakeDriver is compatible with the postgres dialect

This PR adds:

"*gosnowflake.SnowflakeDriver": &postgres, 

to driverDialect, which required reformatting the map literal and made the diff messy 😄

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #14 into master will decrease coverage by 2.22%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   86.84%   84.61%   -2.23%     
==========================================
  Files           2        2              
  Lines          76       78       +2     
==========================================
  Hits           66       66              
- Misses          6        8       +2     
  Partials        4        4              
Impacted Files Coverage Δ
dialect.go 90.90% <0.00%> (-9.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a80db41...bd7c94f. Read the comment docs.

@jimsmart
Copy link
Owner

Thanks for your pull request, appreciated.

I've just added support for the Snowflake driver, as described in your initial commit, in v0.0.5.

The main issue with supporting Snowflake is that we have no way to easily test it, being a commercial service with no open/free offering (beyond a free trial) — this makes it somewhat difficult to test locally or to set up in a CI environment.

Due to this, I see no value in adding non-running tests for Snowflake to the codebase, currently.

According to their docs identifier escaping in Snowflake is performed using double quotes, which is the same as Postgres — so I have not included the changes from your later commit providing unescaped identifiers for Snowflake.

HTH

@jimsmart
Copy link
Owner

I've filed an issue to track this lack of testing.

@hundredwatt hundredwatt deleted the snowflake branch August 1, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants