Skip to content
This repository has been archived by the owner on May 25, 2018. It is now read-only.

adding faye-browser-min.js.map #13

Merged
merged 1 commit into from
Jun 30, 2012
Merged

Conversation

aaronjensen
Copy link
Collaborator

The client 404s without it

@aaronjensen
Copy link
Collaborator Author

I pulled this from the faye gem, hopefully it's the same version as you're using... didn't check that. Also, it really only 404s if you're in dev mode, but it's probably a good thing to have nonetheless.

@RLovelett
Copy link
Contributor

Can you write a test that goes along with this?

@aaronjensen
Copy link
Collaborator Author

Hmm, what exactly would it test? That the file exists in the folder? This is just one of the 4 assets that ships with faye, for some reason there were only 3 of them.

@aaronjensen
Copy link
Collaborator Author

looks like it was removed here: e709ffb

It's not exactly unused, Chrome's dev tools try to pull it down. I'm curious what problems it causes w/ asset precompile, perhaps removing it wasn't the way to deal with that?

Either way, I don't think my pull request should be accepted as is, the right solution would be to revert that commit and possibly fix the asset precompile problem, but there's no details as to what that is.

@jimsynz
Copy link
Owner

jimsynz commented Jun 30, 2012

Agreed. Let's fix the problem properly. I'll merge and we can try and get some tests around it to specify the behaviour that is causing the issue. It should only be used by sprockets in dev and not when running precompile, so it's probably just at we need to exclude it from the build somehow.

jimsynz pushed a commit that referenced this pull request Jun 30, 2012
adding faye-browser-min.js.map
@jimsynz jimsynz merged commit 9f49f48 into jimsynz:master Jun 30, 2012
@jimsynz
Copy link
Owner

jimsynz commented Jun 30, 2012

@tardate Can you provide more info about the problems you encountered?

@tardate
Copy link
Collaborator

tardate commented Jul 1, 2012

@jamesotron I've put the asset pipeline issue details in #15

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants